NIFI-11370 Correct JWK Set retrieval for NIFI Trust Strategy#7108
Merged
mtien-apache merged 1 commit intoapache:mainfrom Mar 31, 2023
Merged
NIFI-11370 Correct JWK Set retrieval for NIFI Trust Strategy#7108mtien-apache merged 1 commit intoapache:mainfrom
mtien-apache merged 1 commit intoapache:mainfrom
Conversation
- Added StandardOidcIdTokenDecoderFactory based on Spring Security OidcIdTokenDecoderFactory with custom REST Operations
Contributor
|
Reviewing. |
mtien-apache
approved these changes
Mar 31, 2023
Contributor
mtien-apache
left a comment
There was a problem hiding this comment.
Thanks for the PR, @exceptionfactory! I tested by changing the default Java cacerts and configured with an ID provider (tested with Okta and Azure). I verified I can log in with both providers.
r-vandenbos
pushed a commit
to r-vandenbos/nifi
that referenced
this pull request
Apr 11, 2023
…e#7108) - Added StandardOidcIdTokenDecoderFactory based on Spring Security OidcIdTokenDecoderFactory with custom REST Operations Merged apache#7108 into main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11370 Corrects JSON Web Key Set retrieval when using the
NIFITrust Store Strategy.The
NIFItrust store strategy can be configured usingnifi.security.user.oidc.truststore.strategyin application properties for integrating with Identity Providers that do not use certificates issued from public authorities.The standard Spring Security OidcIdTokenDecoderFactory implementation does not support providing an instance of
RestOperationsto theNimbusJwtDecoderbuilder, which results in using the default Java trust store instead of the NiFi trust store strategy.The new
StandardOidcIdTokenDecoderFactorysupports a configurable instance ofRestOperations, which is configured in theOidcSecurityConfiguration. The new Decoder Factory supports the same capabilities as the default Spring Security implementation in terms of JWS algorithms allowed.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation