NIFI-11287: detect dependent properties when the property it depends on references a parameter (UI)#7117
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for working on this improvement @mtien-apache! The automated builds failed due to several JavaScript syntax issues, such as defining a default value for option on line 1882.
|
Thanks for reviewing, @exceptionfactory! I fixed the syntax errors and addressed your comments. Would you look again? |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for correcting the syntax issues @mtien-apache. I noted a couple additional questions on the implementation itself.
…on references a parameter
- retrieve the parameter context with ajax call from inside the class
|
I changed the way @exceptionfactory can you check again? Thanks! |
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the PR @mtien-apache and thanks for the review @exceptionfactory. I think we can simplify the code within the Property Table because we should already be able to fetch the Parameter Context.
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the additional changes @mtien-apache, I will defer to @mcgilman for final review.
…on references a parameter (UI) (#7117) * NIFI-11287: detect dependent properties when the property it depends on references a parameter * address review feedback * address more review comments * - loadProperties checks type before getting the parameter context - retrieve the parameter context with ajax call from inside the class * add type parameter to all places calling loadProperties * get reference parameters by invoking provided callbacks from the client * check for user permissions before requesting for referenced parameters * address review feedback This closes #7117
!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
Summary
NIFI-11287 (UI)
To test:
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation