[NIFI-2367] [NIFI-2025] [NIFI-2107] [NIFI-2355] [NIFI-2027] [NIFI-2387] [NIFI-2141] [NIFI-2400] [NIFI-2404]#715
Closed
scottyaslan wants to merge 17 commits intoapache:masterfrom
Closed
Conversation
scottyaslan
force-pushed
the
responsiveDevBranch
branch
from
42151c8 to
8069eff
Compare
scottyaslan
changed the title
scottyaslan
changed the title
scottyaslan
changed the title
scottyaslan
changed the title
scottyaslan
changed the title
scottyaslan
changed the title
Contributor
|
Reviewing... |
scottyaslan
force-pushed
the
responsiveDevBranch
branch
from
ddd7a20 to
ee4ef42
Compare
added 14 commits
July 26, 2016 17:36
…the color of the icon not the div background
scottyaslan
force-pushed
the
responsiveDevBranch
branch
from
ee4ef42 to
551a046
Compare
| // update the tooltip background | ||
| selection.select('rect.bulletin-background').classed('has-bulletins', true); | ||
| selection.select('text.bulletin-icon').style("visibility", "visible"); | ||
| selection.select('rect.bulletin-background').style("visibility", "visible").classed('has-bulletins', true); |
Contributor
There was a problem hiding this comment.
With this proposed change we could remove the has-bulletins class and just integrate those styles into the base style of the bulletin-background since we're only ever showing it when it has bulletins.
Contributor
|
Looks great @scottyaslan! This has been merged to master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.