NIFI-11230: Log Warnings on Startup for OS Best Practices

[emiliosetiadarma]

Summary

NIFI-11230

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 11
  • JDK 17

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for putting this together @emiliosetiadarma! These checks and warnings should be helpful for troubleshooting potential system configuration problems.

The general approach looks good. It looks like there is some potential for reuse across the multiple RuntimeValidator implementations, and aside from that, I noted several minor stylistic recommendations.

[exceptionfactory]

Thanks for making the adjustments @emiliosetiadarma! After some runtime testing, I made some minor adjustments to the warning messages.

I created a getResultBuilder() method in the abstract checker to use getClass().getSimpleName() to avoid logging the full class name for warnings. I also adjusted the warning messages to include the /proc file path so the source of the problem is clear.

With those changes, example output appears as follows:

Runtime Configuration [Swappiness] validation failed: Swappiness [60] more than recommended [0] according to [/proc/sys/vm/swappiness]

With these changes, this should be ready to go following successful automated builds.