Skip to content

NIFI-11034: Restore image viewer to nifi-assembly#7209

Closed
mattyb149 wants to merge 1 commit into
apache:mainfrom
mattyb149:NIFI-11034
Closed

NIFI-11034: Restore image viewer to nifi-assembly#7209
mattyb149 wants to merge 1 commit into
apache:mainfrom
mattyb149:NIFI-11034

Conversation

@mattyb149
Copy link
Copy Markdown
Contributor

Summary

NIFI-11034 This PR creates a nifi-image-viewer-nar and moves the image viewer WAR from the nifi-media-nar to the nifi-image-viewer-nar. The former is not included by default in the assembly, but this PR adds the latter to the assembly so the Image Viewer is always available to the UI. The new NAR is only 16K in size so there should be no concern over the increased footprint.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@asfgit asfgit closed this in 3d60e4a Apr 29, 2023
asfgit pushed a commit that referenced this pull request Apr 30, 2023
This closes #7209

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
@mattyb149
Copy link
Copy Markdown
Contributor Author

@MikeThomsen did you merge this to both branches (main and support-1.x)? Can you update the Fix Version in the Jira to the actual versions (we use the .latest to indicate which lines they should land on. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants