NIFI-11034: Restore image viewer to nifi-assembly#7209
Closed
mattyb149 wants to merge 1 commit into
Closed
Conversation
MikeThomsen
approved these changes
Apr 29, 2023
asfgit
pushed a commit
that referenced
this pull request
Apr 30, 2023
This closes #7209 Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Contributor
Author
|
@MikeThomsen did you merge this to both branches (main and support-1.x)? Can you update the Fix Version in the Jira to the actual versions (we use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11034 This PR creates a
nifi-image-viewer-narand moves the image viewer WAR from thenifi-media-narto thenifi-image-viewer-nar. The former is not included by default in the assembly, but this PR adds the latter to the assembly so the Image Viewer is always available to the UI. The new NAR is only 16K in size so there should be no concern over the increased footprint.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation