NIFI-11222 Added deprecationlogger to MongoDB processors that extend …#7212
Closed
MikeThomsen wants to merge 3 commits into
Closed
NIFI-11222 Added deprecationlogger to MongoDB processors that extend …#7212MikeThomsen wants to merge 3 commits into
MikeThomsen wants to merge 3 commits into
Conversation
…AbstractMongoProcessor.
exceptionfactory
requested changes
May 1, 2023
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for adding the deprecation warnings @MikeThomsen. I noted a recommendation on the logger creation and the warning.
…rc/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…rc/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
Contributor
Author
|
@exceptionfactory @mattyb149 changes made. |
exceptionfactory
approved these changes
May 1, 2023
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @MikeThomsen, the latest version looks good! +1 merging
exceptionfactory
pushed a commit
that referenced
this pull request
May 1, 2023
This closes #7212 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…AbstractMongoProcessor.
Summary
NIFI-11222
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation