NIFI-11524 Documentation and config experience improvement for ExecuteStreamCommand#7228
Closed
nandorsoma wants to merge 2 commits into
Closed
NIFI-11524 Documentation and config experience improvement for ExecuteStreamCommand#7228nandorsoma wants to merge 2 commits into
nandorsoma wants to merge 2 commits into
Conversation
nandorsoma
commented
May 4, 2023
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the additional documentation and improvements @nandorsoma! I just noted a couple very minor things, otherwise this should be ready to go.
Contributor
Author
|
Thank you for your review @exceptionfactory! Please see my latest commit where I applied your suggestions. |
exceptionfactory
approved these changes
May 11, 2023
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @nandorsoma, the latest version looks good! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11524
This PR indends to add documentation for the ExecuteSteamCommand processor and improves the configuration experience by adding dependency between properties.
I've noticed that the processor adds every Dynamic Property as environment variable even when it is a command argument. I didn't change this behavior because it might introduce a breaking change, but I'd change this behavior in a separate 2.0 only PR. Simply adding another regex check there would introduce the 4. regex check which is quite ugly so it would be a good opportunity for refactor. Another option would be to add validation for environment variables to ensure they don't contain
.character, because most shells don't support it. But I'm not sure about that because there are commands that can utilize such env variables even though they are not common.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation