NIFI-1663: Add ConvertAvroToORC processor#727
NIFI-1663: Add ConvertAvroToORC processor#727mattyb149 wants to merge 3 commits intoapache:masterfrom
Conversation
|
Reviewing |
| /** | ||
| * Utility methods for ORC support (conversion from Avro, conversion to Hive types, e.g. | ||
| */ | ||
| public class NiFiOrcUtils { |
There was a problem hiding this comment.
No, I will reduce the visibility. For util classes I usually start them as public, but since it's unlikely this NAR will be the parent/dependency of another, public is not needed
There was a problem hiding this comment.
Actually it does have to be public, it is referenced from multiple packages.
|
I see a few comments about PutHiveStreaming, that is part of a previous commit that is being handled under #706, it's just in here in order to inherit the downgrade of Hive. |
mattyb149
force-pushed
the
old_orc
branch
3 times, most recently
from
8082e95 to
242e4dc
Compare
|
Closing the PR and cancelling the current patch as there are issues with complex types, will reopen once fixed |
|
Aside from minor stylistic things (didn't comment on them), I am +1. Verified new tests, all pass. Test coverage on the overall module is high. |
2 participants
This PR is based on #706 which removed the ConvertAvroToORC processor using Hive 2.x and Apache ORC 1.x. This PR replaces that processor with one that uses Hive 1.2.1 (which includes hive-orc before it was split into its own Apache project).