Skip to content

NIFI-11640: Update download-maven-plugin to 1.6.8#7337

Closed
r-sidd wants to merge 2 commits into
apache:mainfrom
r-sidd:NIFI-11640
Closed

NIFI-11640: Update download-maven-plugin to 1.6.8#7337
r-sidd wants to merge 2 commits into
apache:mainfrom
r-sidd:NIFI-11640

Conversation

@r-sidd

@r-sidd r-sidd commented Jun 3, 2023

Copy link
Copy Markdown
Contributor

Summary

NIFI-11640

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r-sidd Were you able to run a successful full build with these changes? All of the automated builds fail due to the change for nifi-registry-web-api, which implies that some additional configuration adjustment is necessary.

@r-sidd

r-sidd commented Jun 4, 2023

Copy link
Copy Markdown
Contributor Author

@r-sidd Were you able to run a successful full build with these changes? All of the automated builds fail due to the change for nifi-registry-web-api, which implies that some additional configuration adjustment is necessary.

Let me check what is the issue 😢

@r-sidd r-sidd requested a review from exceptionfactory June 4, 2023 17:22
@r-sidd

r-sidd commented Jun 4, 2023

Copy link
Copy Markdown
Contributor Author

@r-sidd Were you able to run a successful full build with these changes? All of the automated builds fail due to the change for nifi-registry-web-api, which implies that some additional configuration adjustment is necessary.

I downgraded the version from 1.7.0 to 1.6.8 (which doesn't have any findings). Built in local and tested. Hope that is fine 🙂.

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustment @r-sidd, it looks like the incremental update to 1.6.8 works, and upgrading to 1.7.0 could be considered as a follow on issue. I will adjust the issue title accordingly. +1 merging

@r-sidd

r-sidd commented Jun 5, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for making the adjustment @r-sidd, it looks like the incremental update to 1.6.8 works, and upgrading to 1.7.0 could be considered as a follow on issue. I will adjust the issue title accordingly. +1 merging

Yes great, thanks 🙂

@exceptionfactory exceptionfactory changed the title NIFI-11640: Update download-maven-plugin to 1.7.0 NIFI-11640: Update download-maven-plugin to 1.6.8 Jun 5, 2023
exceptionfactory pushed a commit that referenced this pull request Jun 5, 2023
This closes #7337

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 0cd511f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants