Skip to content

NIFI-11643: Upgrade geoip2 to 4.0.1#7341

Closed
r-sidd wants to merge 1 commit intoapache:mainfrom
r-sidd:NIFI-11643
Closed

NIFI-11643: Upgrade geoip2 to 4.0.1#7341
r-sidd wants to merge 1 commit intoapache:mainfrom
r-sidd:NIFI-11643

Conversation

@r-sidd
Copy link
Copy Markdown
Contributor

@r-sidd r-sidd commented Jun 5, 2023

Summary

NIFI-11643

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@r-sidd
Copy link
Copy Markdown
Contributor Author

r-sidd commented Jun 5, 2023

@exceptionfactory can you review this pls? Build success in local 🙂

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 4.0.1 includes changes from 3.0.0 that require Java 11 as the minimum version, so this should be suitable for inclusion on the main branch, but cannot be backported to the version 1 support branch.

@r-sidd
Copy link
Copy Markdown
Contributor Author

r-sidd commented Jun 6, 2023

Version 4.0.1 includes changes from 3.0.0 that require Java 11 as the minimum version, so this should be suitable for inclusion on the main branch, but cannot be backported to the version 1 support branch.

Cool, how should we go about it 🙂

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r-sidd, this upgrade looks good for the main branch. This cannot be backported to the support branch due to Java 11 requirements, but this is helpful for the next major release version. +1 merging

@r-sidd
Copy link
Copy Markdown
Contributor Author

r-sidd commented Jun 7, 2023

Thanks @r-sidd, this upgrade looks good for the main branch. This cannot be backported to the support branch due to Java 11 requirements, but this is helpful for the next major release version. +1 merging

Cool 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants