NIFI-11655: Fixed float and double handling in GenerateRecord#7356
Closed
mattyb149 wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-11655: Fixed float and double handling in GenerateRecord#7356mattyb149 wants to merge 1 commit intoapache:mainfrom
mattyb149 wants to merge 1 commit intoapache:mainfrom
Conversation
exceptionfactory
approved these changes
Jun 8, 2023
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the correction @mattyb149! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11655 This PR fixes how floats and doubles are generated when using the Schema Text property in GenerateRecord. The bug was that all types were coerced to DecimalDataType which is not compatible for float and double types. The PR handles each of the types separately, and test data was added to exercise this fix.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-11655NIFI-11655Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation