NIFI-11673 Remove Legacy TLS Configuration Versions#7367
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-11673 Remove Legacy TLS Configuration Versions#7367exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
1d1dfd9 to
5218e45
Compare
5218e45 to
3083a5a
Compare
Contributor
|
This would be great to implement!! |
nandorsoma
approved these changes
Jun 23, 2023
Contributor
nandorsoma
left a comment
There was a problem hiding this comment.
Thanks for the change @exceptionfactory! Tested on a secured cluster, LGTM. Merging to main.
nandorsoma
reviewed
Jun 23, 2023
Contributor
nandorsoma
left a comment
There was a problem hiding this comment.
Noticed test failures in the nifi-toolkit-tls module in my last build after rebase. It could be a local env issue, but for further investigation, I'm revoking my approval for safety's sake.
Contributor
|
It was an env issue. Merging to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11673 Removes legacy TLS protocol versions from the
TlsConfigurationinterface along with methods based on evaluation of Java version information.Previous logic defaulted to TLSv1.2 for Java 8 and TLSv1.3 for Java 11 when calling several helper methods on
TlsConfiguration. TheTlsPlatformutility class provides feature-based detection and has been used in a number of framework and extension components. With the removal of Java 8 support from the main branch, the Java version number checking is no longer necessary.Additional changes include applying the
SSL Protocolproperty to the HTTP Notification Service for NiFi Bootstrap and removing test methods no longer necessary with the standardization of available TLS protocol versions.For cluster socket communication, the
TlsPlatformmethods replace the Java version-based methods fromTlsConfigurationwhile providing equivalent functionality.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation