Skip to content

NIFI-11638 Refactored Groovy tests in nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors to Java (and JUnit 5)#7408

Closed
dan-s1 wants to merge 2 commits into
apache:mainfrom
dan-s1:NIFI-11638
Closed

NIFI-11638 Refactored Groovy tests in nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors to Java (and JUnit 5)#7408
dan-s1 wants to merge 2 commits into
apache:mainfrom
dan-s1:NIFI-11638

Conversation

@dan-s1
Copy link
Copy Markdown
Contributor

@dan-s1 dan-s1 commented Jun 19, 2023

Summary

NIFI-11638

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…nifi-cdc-mysql-processors to Java (and JUnit 5)
Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor work @dan-s1! With these changes, can the groovy-json test dependency be removed from nifi-cdc-mysql-processors?

@dan-s1
Copy link
Copy Markdown
Contributor Author

dan-s1 commented Jun 19, 2023

@exceptionfactory I removed it. Thanks for bringing that to my attention. I did not realize that dependency was there.

@mattyb149
Copy link
Copy Markdown
Contributor

+1 LGTM, thanks for the improvement! Merging to support/nifi-1.x and main

@mattyb149 mattyb149 closed this in 5db0643 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants