NIFI-11732 Update Saxon-HE to 12.2#7414
Closed
mr1716 wants to merge 2 commits into
Closed
Conversation
exceptionfactory
requested changes
Jun 20, 2023
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Saxon 12.2 apparently introduced serialization changes for HTML5 that changed the newline output, breaking the unit tests. Did you run a full build locally @mr1716?
I should be able to take a closer look soon, and the change should be simple enough that the unit tests could be updated to match the expected behavior.
Contributor
|
@mr1716 I adjusted the spacing for the two example HTML outputs to match the serialization changes in Saxon 12.2. This is not a concern for runtime behavior, but reflects the comparison checks of the test code. Planning to merge pending successful builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11732
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation