Skip to content

NIFI-11732 Update Saxon-HE to 12.2#7414

Closed
mr1716 wants to merge 2 commits into
apache:mainfrom
mr1716:NIFI-11732
Closed

NIFI-11732 Update Saxon-HE to 12.2#7414
mr1716 wants to merge 2 commits into
apache:mainfrom
mr1716:NIFI-11732

Conversation

@mr1716
Copy link
Copy Markdown
Contributor

@mr1716 mr1716 commented Jun 20, 2023

Summary

NIFI-11732

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saxon 12.2 apparently introduced serialization changes for HTML5 that changed the newline output, breaking the unit tests. Did you run a full build locally @mr1716?

I should be able to take a closer look soon, and the change should be simple enough that the unit tests could be updated to match the expected behavior.

@exceptionfactory
Copy link
Copy Markdown
Contributor

@mr1716 I adjusted the spacing for the two example HTML outputs to match the serialization changes in Saxon 12.2. This is not a concern for runtime behavior, but reflects the comparison checks of the test code. Planning to merge pending successful builds.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 merging

exceptionfactory added a commit that referenced this pull request Jun 21, 2023
- Adjusted spacing in test HTML to match Saxon 12.2 serialization

This closes #7414

Co-authored-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit f62e1eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants