Skip to content

NIFI-11754 Refactored Groovy test in nifi-jetty to Java (and JUnit 5)#7442

Closed
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-11754
Closed

NIFI-11754 Refactored Groovy test in nifi-jetty to Java (and JUnit 5)#7442
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-11754

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Jun 26, 2023

Summary

NIFI-11754

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@dan-s1
Copy link
Contributor Author

dan-s1 commented Jun 26, 2023

@exceptionfactory I was able to refactor the unit test and test it locally but I am not sure why though when I run
mvn clean install -P contrib-check
the tests in the nifi-jetty module are skipped.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Jun 27, 2023

@exceptionfactory Can you please restart the flows which failed? I do not think the errors were related to my changes. Thanks!

@dan-s1
Copy link
Contributor Author

dan-s1 commented Jun 27, 2023

@exceptionfactory Hmm again the failure does not relate to my change.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, the changes look good, the system test failure is unrelated. +1 merging

exceptionfactory pushed a commit that referenced this pull request Jun 27, 2023
This closes #7442

Signed-off-by: David Handermann <exceptionfactory@apache.org>

(cherry picked from commit 2a7fa6d)
@dan-s1
Copy link
Contributor Author

dan-s1 commented Jun 27, 2023

@exceptionfactory Thank you for accepting my PR and merging. I still do have a remaining question. I looked at the raw logs from the build(s) yet I do not see org.apache.nifi.web.server.HostHeaderHandlerTest being run. What am I missing?

@exceptionfactory
Copy link
Contributor

@dan-s1 The GitHub Actions builds have the default log level set to warning, so they do not print every test class status. This may be something to revisit, but it does generate a lot of output. The HostHeaderHandlerTest shows up in a local build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants