NIFI-11754 Refactored Groovy test in nifi-jetty to Java (and JUnit 5)#7442
NIFI-11754 Refactored Groovy test in nifi-jetty to Java (and JUnit 5)#7442dan-s1 wants to merge 1 commit intoapache:mainfrom
Conversation
|
@exceptionfactory I was able to refactor the unit test and test it locally but I am not sure why though when I run |
|
@exceptionfactory Can you please restart the flows which failed? I do not think the errors were related to my changes. Thanks! |
|
@exceptionfactory Hmm again the failure does not relate to my change. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @dan-s1, the changes look good, the system test failure is unrelated. +1 merging
|
@exceptionfactory Thank you for accepting my PR and merging. I still do have a remaining question. I looked at the raw logs from the build(s) yet I do not see |
|
@dan-s1 The GitHub Actions builds have the default log level set to warning, so they do not print every test class status. This may be something to revisit, but it does generate a lot of output. The |
Summary
NIFI-11754
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation