NIFI-11877 add a Comments field for Rules in UpdateAttribute processor#7541
NIFI-11877 add a Comments field for Rules in UpdateAttribute processor#7541markobean wants to merge 1 commit intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
@markobean Can you rebase this pull request on the latest main branch? Recent changes addressed issues with failing QuestDB tests, so it would be helpful to incorporate those changes and confirm clean automated builds.
Rebased, ran build with |
|
@exceptionfactory Any additional comments on this one? Or can we stick a fork in it and merge? |
Thanks for the follow up @markobean, I will review the latest updates soon. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for your work on this improvement @markobean, the new Rule Comments field looks good and provides a helpful way to describe functional details for specific Update Attribute Rules. +1 merging
Summary
Added a feature for adding Comments to individual Rules in the Advanced UI of the UpdateAttribute processor. This provides a better location to provide comments as they apply to a particular rule. The only alternative is to document Rules in the Comments tab of the processor. This is too far removed from the Rule to be easy to associate the comment with the Rule - and is highly susceptible to the comment becoming stale relative to rule changes.
NIFI-11877
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
This PR is largely a UI feature. Add Rules in the Advanced UI of UpdateAttribute. Comments are able to be added and persist. Also, when creating a new Rule based on an existing Rule, the Comments field carries forward.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation