Skip to content

NIFI-11877 add a Comments field for Rules in UpdateAttribute processor#7541

Closed
markobean wants to merge 1 commit intoapache:mainfrom
markobean:NIFI-11877
Closed

NIFI-11877 add a Comments field for Rules in UpdateAttribute processor#7541
markobean wants to merge 1 commit intoapache:mainfrom
markobean:NIFI-11877

Conversation

@markobean
Copy link
Copy Markdown
Contributor

Summary

Added a feature for adding Comments to individual Rules in the Advanced UI of the UpdateAttribute processor. This provides a better location to provide comments as they apply to a particular rule. The only alternative is to document Rules in the Comments tab of the processor. This is too far removed from the Rule to be easy to associate the comment with the Rule - and is highly susceptible to the comment becoming stale relative to rule changes.

NIFI-11877

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

This PR is largely a UI feature. Add Rules in the Advanced UI of UpdateAttribute. Comments are able to be added and persist. Also, when creating a new Rule based on an existing Rule, the Comments field carries forward.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markobean Can you rebase this pull request on the latest main branch? Recent changes addressed issues with failing QuestDB tests, so it would be helpful to incorporate those changes and confirm clean automated builds.

@markobean
Copy link
Copy Markdown
Contributor Author

@markobean Can you rebase this pull request on the latest main branch? Recent changes addressed issues with failing QuestDB tests, so it would be helpful to incorporate those changes and confirm clean automated builds.

Rebased, ran build with -Pcontrib-check, pushed.

@markobean
Copy link
Copy Markdown
Contributor Author

@exceptionfactory Any additional comments on this one? Or can we stick a fork in it and merge?

@exceptionfactory
Copy link
Copy Markdown
Contributor

@exceptionfactory Any additional comments on this one? Or can we stick a fork in it and merge?

Thanks for the follow up @markobean, I will review the latest updates soon.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this improvement @markobean, the new Rule Comments field looks good and provides a helpful way to describe functional details for specific Update Attribute Rules. +1 merging

exceptionfactory pushed a commit that referenced this pull request Aug 22, 2023
This closes #7541

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 9432f30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants