NIFI-2444 NIFI-2445 fixed PublishKafka#758
Closed
olegz wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Contributor
olegz
commented
Aug 1, 2016
olegz
commented
- fixed the logging issue NIFI-2444 by ensuring the ProcessLog is added to KafkaPublisher
- fixed KafkaPublisher's isAllAcked operation to ensure that it properly reports that the flow file has failed.
- added additional test
Contributor
|
@olegz the KafkaPublisher class is now logging everything twice. I think we need to get rid of the internal logger and use only the Processor Logger. |
olegz
force-pushed
the
NIFI-2444
branch
2 times, most recently
from
86daf9f to
c62d9a9
Compare
- fixed the logging issue NIFI-2444 by ensuring the ProcessLog is added to KafkaPublisher - fixed KafkaPublisher's isAllAcked operation to ensure that it properly reports that the flow file has failed. - added additional test
olegz
force-pushed
the
NIFI-2444
branch
2 times, most recently
from
696d257 to
4bf8257
Compare
Contributor
|
All looks good now. I was able to verify that contrib-check passes. All unit tests pass and all compiles. Was able to deploy to same system that was having problems before and see that all FlowFiles are now routed to 'failure' as appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.