Skip to content

NIFI-11934 allow FlowFile filename to be transmitted in HTTP header f…#7639

Closed
markobean wants to merge 2 commits intoapache:mainfrom
markobean:NIFI-11934
Closed

NIFI-11934 allow FlowFile filename to be transmitted in HTTP header f…#7639
markobean wants to merge 2 commits intoapache:mainfrom
markobean:NIFI-11934

Conversation

@markobean
Copy link
Contributor

…or InvokeHTTP

Summary

Removed 'filename' from the list of attributes to exclude when sending FlowFIle attributes using InvokeHTTP. Updated some of the documentation as well.
NIFI-11934

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Instantiate InvokeHTTP and set 'Request Header Attributes Pattern' to ".*" (or any other value which will include the "filename" attribute.) Receive FlowFile with a corresponding ListenHTTP. Verify 'filename' is as expected (same as FlowFile that was transferred.)

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustment @markobean. The documentation updates are helpful in light of the propose change for the filename attribute filtering. I noted a couple minor documentation adjustment recommendations.

@markobean
Copy link
Contributor Author

Thanks @exceptionfactory. I pushed changes per recommendations.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @markobean, looks good! +1 merging

exceptionfactory pushed a commit that referenced this pull request Aug 24, 2023
This closes #7639

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit d1b7701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants