NIFI-11934 allow FlowFile filename to be transmitted in HTTP header f…#7639
Closed
markobean wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-11934 allow FlowFile filename to be transmitted in HTTP header f…#7639markobean wants to merge 2 commits intoapache:mainfrom
markobean wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the adjustment @markobean. The documentation updates are helpful in light of the propose change for the filename attribute filtering. I noted a couple minor documentation adjustment recommendations.
...e/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
Outdated
Show resolved
Hide resolved
...e/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @exceptionfactory. I pushed changes per recommendations. |
exceptionfactory
approved these changes
Aug 24, 2023
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the updates @markobean, looks good! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or InvokeHTTP
Summary
Removed 'filename' from the list of attributes to exclude when sending FlowFIle attributes using InvokeHTTP. Updated some of the documentation as well.
NIFI-11934
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Instantiate InvokeHTTP and set 'Request Header Attributes Pattern' to ".*" (or any other value which will include the "filename" attribute.) Receive FlowFile with a corresponding ListenHTTP. Verify 'filename' is as expected (same as FlowFile that was transferred.)
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation