Skip to content

NIFI-12028 - Add s3.region attribute to ListS3 generated flow files#7672

Closed
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-12028
Closed

NIFI-12028 - Add s3.region attribute to ListS3 generated flow files#7672
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-12028

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-12028 - Add s3.region attribute to ListS3 generated flow files

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@markap14
Copy link
Contributor

markap14 commented Sep 8, 2023

Thanks for putting this up @pvillard31. I did some quick testing, and all looks good with default settings. However, whenever I specify a Record Writer, it looks like the region is not output in the created Record. Can you update the Record-oriented case to output the region also, so that the two stay in-sync?

@pvillard31
Copy link
Contributor Author

Hey @markap14 - yeah so I decided that even if using a record writer, I'd add the region as an attribute instead of adding it to each record since the region would be the same for each record already and I'm not sure to see any value adding it into a record. If you think differently, I can easily add it to the records as well.

@asfgit asfgit closed this in 47f4c8c Sep 10, 2023
asfgit pushed a commit that referenced this pull request Sep 10, 2023
This closes #7672

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
prabhjyotsingh pushed a commit to acceldata-io/nifi that referenced this pull request Aug 26, 2025
This closes apache#7672

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
(cherry picked from commit 5be76cd)
prabhjyotsingh pushed a commit to acceldata-io/nifi that referenced this pull request Aug 26, 2025
…ow files

This closes apache#7672

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
(cherry picked from commit 5be76cd)
prabhjyotsingh pushed a commit to acceldata-io/nifi that referenced this pull request Aug 26, 2025
…ow files

This closes apache#7672

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
(cherry picked from commit 5be76cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants