NIFI-12028 - Add s3.region attribute to ListS3 generated flow files#7672
Closed
pvillard31 wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-12028 - Add s3.region attribute to ListS3 generated flow files#7672pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Thanks for putting this up @pvillard31. I did some quick testing, and all looks good with default settings. However, whenever I specify a Record Writer, it looks like the region is not output in the created Record. Can you update the Record-oriented case to output the region also, so that the two stay in-sync? |
Contributor
Author
|
Hey @markap14 - yeah so I decided that even if using a record writer, I'd add the region as an attribute instead of adding it to each record since the region would be the same for each record already and I'm not sure to see any value adding it into a record. If you think differently, I can easily add it to the records as well. |
MikeThomsen
approved these changes
Sep 10, 2023
asfgit
pushed a commit
that referenced
this pull request
Sep 10, 2023
This closes #7672 Signed-off-by: Mike Thomsen <mthomsen@apache.org>
prabhjyotsingh
pushed a commit
to acceldata-io/nifi
that referenced
this pull request
Aug 26, 2025
This closes apache#7672 Signed-off-by: Mike Thomsen <mthomsen@apache.org> (cherry picked from commit 5be76cd)
prabhjyotsingh
pushed a commit
to acceldata-io/nifi
that referenced
this pull request
Aug 26, 2025
…ow files This closes apache#7672 Signed-off-by: Mike Thomsen <mthomsen@apache.org> (cherry picked from commit 5be76cd)
prabhjyotsingh
pushed a commit
to acceldata-io/nifi
that referenced
this pull request
Aug 26, 2025
…ow files This closes apache#7672 Signed-off-by: Mike Thomsen <mthomsen@apache.org> (cherry picked from commit 5be76cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12028 - Add s3.region attribute to ListS3 generated flow files
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation