Skip to content

NIFI-12021 Refactored and placed Groovy unit tests into the already existing Java unit test classes and some other small refactors#7674

Closed
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-12021
Closed

NIFI-12021 Refactored and placed Groovy unit tests into the already existing Java unit test classes and some other small refactors#7674
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-12021

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Sep 8, 2023 •
edited
Loading

Summary

NIFI-12021

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@dan-s1
NIFI-12021 Refactored and placed Groovy unit tests into the already e…
c11b35c 
…xisting Java unit tests and some other small refactors.
@dan-s1 dan-s1 changed the title NIFI-12021 Refactored and placed Groovy unit tests into the already e… NIFI-12021 Refactored and placed Groovy unit tests into the already existing Java unit test classes and some other small refactors Sep 8, 2023
exceptionfactory
exceptionfactory approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring and cleanup of these tests @dan-s1, looks good! +1 merging

exceptionfactory pushed a commit that referenced this pull request Sep 11, 2023
@dan-s1 @exceptionfactory
NIFI-12021 Refactored Groovy TLS Toolkit Tests to Java
3cd4845 
This closes #7674

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 796ae2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dan-s1 @exceptionfactory