Skip to content

NIFI-11959 Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored.#7678

Closed
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-11959
Closed

NIFI-11959 Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored.#7678
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-11959

Conversation

@dan-s1
Copy link
Copy Markdown
Contributor

@dan-s1 dan-s1 commented Sep 11, 2023 •
edited
Loading

Summary

NIFI-11959

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@dan-s1
NIFI-11959 Added new lines back to the read in JSON spec to allow for…
28bd82f 
… single line comments to be parsed correctly and ignored.
exceptionfactory
exceptionfactory approved these changes Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction and tests @dan-s1, looks good! +1 merging

exceptionfactory pushed a commit that referenced this pull request Sep 11, 2023
@dan-s1 @exceptionfactory
NIFI-11959 Corrected single-line comment handling for Jolt JSON
b468d4f 
Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored.

This closes #7678

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 0280497)
@dan-s1 dan-s1 mentioned this pull request Oct 20, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dan-s1 @exceptionfactory