NIFI-12051 Moving to latest groovy 4.x 4.0.15 and migrating to org.apache instead of legacy org.codehaus packages. Closer to Java 21 readiness#7692
Closed
joewitt wants to merge 3 commits intoapache:mainfrom
Closed
Conversation
joewitt
changed the title
joewitt
force-pushed
the
NIFI-12051
branch
2 times, most recently
from
c89c87a to
2d5cbb3
Compare
9 tasks
Contributor
Author
|
will force push an update soon to rebase off the latest improvements in main. |
joewitt
force-pushed
the
NIFI-12051
branch
3 times, most recently
from
a07b8d5 to
3284567
Compare
exceptionfactory
requested changes
Sep 15, 2023
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
The majority of these changes appear to be straightforward, pending some confirmation of basic Groovy 4 compatibility. I noted two modules where the Groovy dependencies can be removed completely because there are no longer any Groovy-based tests.
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/pom.xml
Outdated
Show resolved
Hide resolved
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml
Outdated
Show resolved
Hide resolved
…ache instead of legacy org.codehaus packages. Closer to Java 21 readiness
exceptionfactory
approved these changes
Sep 15, 2023
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @joewitt, the latest version looks good! +1 merging to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s. Doesnt appear to work with Groovy 4x.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation