NIFI-12118: Removed member variable that was caching values that invo…#7783
Closed
markap14 wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-12118: Removed member variable that was caching values that invo…#7783markap14 wants to merge 1 commit intoapache:mainfrom
markap14 wants to merge 1 commit intoapache:mainfrom
Conversation
…lve property values post-expression language evaluation. Made the List a local variable instead. Also changed a regex from using Pattern.matcher().match() with a .* at the start to just use Pattern.matcher().find() for efficiency purposes.
ChrisSamo632
approved these changes
Sep 23, 2023
Contributor
ChrisSamo632
left a comment
ChrisSamo632
left a comment
There was a problem hiding this comment.
Thanks for the fix @markap14 , LGTM 👍 , will merge
asfgit
pushed a commit
that referenced
this pull request
Sep 23, 2023
…ing values, and improve performance with Pattern.matcher().find() instead of .match(). This closes #7783 Signed-off-by: Chris Sampson <chris.sampson82@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lve property values post-expression language evaluation. Made the List a local variable instead. Also changed a regex from using Pattern.matcher().match() with a .* at the start to just use Pattern.matcher().find() for efficiency purposes.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation