NIFI-12074 updated images to base on Java 21 and added Python3#7785
NIFI-12074 updated images to base on Java 21 and added Python3#7785markap14 merged 2 commits intoapache:mainfrom
Conversation
|
The resulting image grew from 1.7GB to 2.2GB. Most of this is from the inclusion of Python3 which we'll want so users can leverage the new Python capabilities in NiFi 2.x. We will need to find ways to reduce the overall size more as we go. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting together these changes @joewitt! Switching to the BellSoft Liberica JDK image looks good, which aligns with the default JDK that Spring Framework builds use for container images.
I also agree with disabling plain HTTP access given the inherent security issues. We should evaluate removing plain HTTP access completely in a separate issue, but these changes look good.
I would like to do some testing, but the changes look straightforward on initial review. If others get to reviewing this before I have the opportunity to test, no need to wait for further review, but I will try to follow up soon.
|
Thanks @joewitt and @exceptionfactory . I did some light testing. I was able to verify that it started up as expected running Java 21 and that Python is installed. Unfortunately, though, it does not uncomment the line in nifi.properties needed in order to enable Python processors. Probably should get that line uncommented in the docker image. Otherwise, all looks good to me. |
|
Thanks for the update @joewitt . Looks good to me. Was able to bring it up, pointing to my local branch's |
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation