Skip to content

NIFI-604: Custom Argument Delimiters ExecuteStreamCommand / ExecuteProcess#78

Merged
asfgit merged 1 commit intoapache:masterfrom
rickysaltzer:NIFI-604
Sep 25, 2015
Merged

NIFI-604: Custom Argument Delimiters ExecuteStreamCommand / ExecuteProcess#78
asfgit merged 1 commit intoapache:masterfrom
rickysaltzer:NIFI-604

Conversation

@rickysaltzer
Copy link
Contributor

  • Unified the way ExecuteStreamCommand and ExecuteProcess handle arguments. This enables
    the ExecuteStreamCommand to use semicolons as part of arguments.
  • Argument delimiters can now be specified. Their default being what they were using before (ExecuteStreamCommand -> ';' , ExecuteProcess -> ' ')

…ocess

- Unified the way ExecuteStreamCommand and ExecuteProcess handle arguments
- Argument delimiters can now be specified. Their default being what they were using before (; and space)
@rickysaltzer
Copy link
Contributor Author

There's one thing I would like to call attention to. Users of the StreamCommand who were using \n \r or \t characters outside of quotes might have unexpected results since the ExecuteProcess command used those as delimiters in addition to the space delimiter. It's doubtful that a lot of people were doing this, but it's something to consider.

One option is to have a "Use Default Delimiters" checkbox that's enabled by default on the ExecuteProcess and disabled by default on the ExecuteStreamCommand.

@asfgit asfgit merged commit 9cefc4a into apache:master Sep 25, 2015
JPercivall pushed a commit to JPercivall/nifi that referenced this pull request Apr 23, 2018
…p.conf to avoid blocking on VM deployment.

This closes apache#78.

Signed-off-by: Aldrin Piri <aldrin@apache.org>
iadamcsik pushed a commit to iadamcsik/nifi that referenced this pull request Oct 22, 2025
…ion (apache#33)

- Adding VersionControlSystemType to VersionedFlowCoordinates and VersionControlInformation
- Updating flow serializers to persist new fields
- Updating flow synchronization to repopulate new fields
- Separate creation of FlowDesignerClient and registering of control handler
- Introduce FlowDesignerService as central point for coordination between framewrk and FlowDesignerClient
- Add flowId and flowRevision to control events and store them in VersionedFlowCoordinate, use flowId from change events to locate target PG
- Add parameter contexts to FlowCreatedEvent so flow designer can send any contexts that may be referenced in the initial flow content
- Use compatible bundle when adding processor from flow change event
- Publish runtime manifest to a well known key in Redis
- Switch to using byte[] for the value of messages in Redis Streams
- Use StringRedisTemplate with our own ObjectMapper for key/values

CDPDFX-4257: Rename consumer.group/name to node.identifier and add no… (apache#34)

* Rename consumer.group/name to node.identifier and add node.identifier caching
* Adding flow status upon flow change or creation events
* Addressing code review comments
* Updating keys

CDPDFX-4280 Refactor how flow designer events are consumed
- Introduce EventContainer to pass along stream name and offset
- Add the offset to VersionControlInformation/VersionFlowCoordinates
- Add new event retrieval methods to FlowDesignerClient
- Add polling tasks for control channel and flow changes
- Move node identifier from Redis impl to framework level
- Store control channel offset in FlowController and serialize to flow.xml/flow.json
- Separate FlowDesignerService into a task manager, control handler, and change handler

CDPDFX-4301: Adding component validation after processor events are h… (apache#36)

* Adding component validation after processor events are handled
* Minor updates based on testing
* Using versioned id for processors
* Adding FlowValidationTask

CDPDFX-4313 Improvement error handling when interacting with FlowDesignerClient
- Improve polling tasks to slowly back off and keep retrying until success
- Move manifest publishing and node registration to schedule tasks

Move initiation of node removal to offload instead of disconnect, add a task to keep retrying node removal

CDPDFX-4572: Publishing status, validation, and bulletins to FD streams (apache#38)

* Adding feedback events to Redis stream
* Publishing validation, status, and bulletins to flow designer streams
* Adding FeedbackEventHandler to framework api
* Updates for code review
* Renaming feedback event handler method

CDPDFX-4955 Integrate component synchronization into StandardFlowChan… (apache#40)

* CDPDFX-4955 Integrate component synchronization into StandardFlowChangeEventHandler
- Rename FlowStatus to FlowRevisionStatus to be more clear
- Add a scheduled task to report revision status
- Add FlowDesignerIT to nifi-system-test
- Handle nested components when processing change events

* Improvements from review feedback

* Update license headers in service loader files

CDPDFX-5242: Fixing bulletin bugs, increasing Redis pool config (apache#41)

CDPDFX-5242: Fixing build after rebase

CDPDFX-5229 Correct TLS enabled logic in RedisFlowDesignerClient

CDPDFX-5134: Publishing remote port status for flow designer (apache#43)

CDPDFX-5353 Publish mapping from versioned component id to component id (apache#45)

* CDPDFX-5353 Publish mapping from versioned component id to component id

* Upates to handle removing component id mappings

* Add node id to the key for publishing component ids

CDPDFX-5233: Adding batchCount/batchId to FlowChangeEvent (apache#49)

* CDPDFX-5233: Adding batchCount/batchId to FlowChangeEvent
* Changing FlowChangeEvent.batchId to a String

CDPDFX - Fix flow change handler after 1.16.2 changes (apache#50)

CDPDFX-5233: Publishing status after each flow change event

CDPDFX-5233: Adding revision info to FlowChangeEvent

CDPDFX-5473: Expanding scope of FlowValidationTask

CDPDFX - Fix JettyServer after rebasing

CDPDFX-5377: Adding Vault parameter service for flow designer (apache#47)

* CDPDFX-5377: Adding Vault Sensitive Parameter Service

* Handling parameter context deletion

CDPDFX-5466: Publishing process group events to FD even for nested pr… (apache#54)

* CDPDFX-5466: Publishing process group events to FD even for nested process groups

* Removing extraneous recursive call

CDPDFX-5377 Removing extraneous TLS dependency (apache#55)

CDPDFX-5466 Remove check preventing child process group status from being published, and ensure all childStatus collections are cleared (apache#56)

CDPDFX-5466 Remove check preventing child process group status from b…

This closes apache#56

CDPDFX-5599 Add process group and RPG counts to process group status feedback (apache#60)

CDPDFX-5415 Separate serialization logic from stream converters so it can be used independently of the stream's Map (apache#61)

CDPDFX-5623: Publishing Controller Service Status to flow designer topic (apache#62)

* CDPDFX-5623: Publishing controller service status to FD
* Correcting FlowStatusTask logic

CDPDFX-5098: Converting runtime manifest to feedback stream (apache#58)

CDPDFX-5428 Setting runtime version as object id for RuntimeManifestEvents (apache#63)

CDPDFX-5623: Handling a NPE in the FlowFeedbackManager, and adding log statements for Vault

CDPDFX-5552: Retrieving param contexts by name instead of ID

CDPDFX-5552: Resolving sensitive parameters in flow created control events

Cdpdfx 5826 (apache#72)

* CDPDFX-5826: Adding configurable feedback task intervals and runtime manifest stream size limit

* Publishing controller service bulletins

* Correcting typo of getBulletinChannelPublishInterval

CDPDFX-6012 Add GZIP compression to contents of runtime manifest stream (apache#76)

CDPDFX-5844: Applying scheduled state changes from NiFi (apache#75)

CDPDFX-5962: Correcting nested process group logic in ComponentIdTask (apache#77)

CDPDFX-5844 Increment VCI version when receiving post processing even… (apache#78)

* CDPDFX-5844 Increment VCI version when receiving post processing event from flow designer

* Fix population of validation feedback key and fix publishing of controller service status at end of change handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants