NIFI-12099 Repurpose Template icon in top left bar

[elcsiga]

Summary

NIFI-12099

import-ftom-registry.mp4

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[sardell]

Reviewing now...

[sardell]

It looks like the draggable icons are no longer centered in their container, which is more obvious when hovering over an icon.

Before your changes:

After:

[rfellows]

reviewing...

[rfellows]

This is good and works pretty well. The only improvement I could recommend would be to refresh the current-user after configuring or deleting a registry client. As it stands now, we are relying on the background polling of the current-user endpoint to update the current user which is where it is determined if canVersionFlows is true or false. It is this property that determines if we show the No Registry Client available dialog or the Import Version dialog.
If you delete the registry client and then try to drag on a new import before the polling happens, you can be shown import dialog with no registries:

Similarly, if you do the same too soon after configuring a registry client, you can get a stale No Registry Client available dialog even though you have one configured.

Maybe @scottyaslan can provide some more insight into if this is consistent with other areas of the application.

[elcsiga]

@rfellows good point, now adding or removing a registry client also reloads /current-user

[rfellows]

Changes look good to me 👍
Thanks @elcsiga