NIFI-12153 allow comments and confiugrable max string size in JSON Record Readers#7823
Closed
ChrisSamo632 wants to merge 3 commits intoapache:mainfrom
Closed
NIFI-12153 allow comments and confiugrable max string size in JSON Record Readers#7823ChrisSamo632 wants to merge 3 commits intoapache:mainfrom
ChrisSamo632 wants to merge 3 commits intoapache:mainfrom
Conversation
exceptionfactory
requested changes
Oct 6, 2023
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for implementing these new properties @ChrisSamo632. The general approach looks good.
As noted in the details, creating an internal default StreamReadConstraints and requiring a non-null value seems like a better default approach going forward.
...d-serialization-services/src/test/java/org/apache/nifi/json/TestJsonTreeRowRecordReader.java
Outdated
Show resolved
Hide resolved
...d-serialization-services/src/test/java/org/apache/nifi/json/TestJsonTreeRowRecordReader.java
Outdated
Show resolved
Hide resolved
...s/nifi-json-record-utils/src/main/java/org/apache/nifi/json/AbstractJsonRowRecordReader.java
Outdated
Show resolved
Hide resolved
...s/nifi-json-record-utils/src/main/java/org/apache/nifi/json/AbstractJsonRowRecordReader.java
Outdated
Show resolved
Hide resolved
...s/nifi-json-record-utils/src/main/java/org/apache/nifi/json/AbstractJsonRowRecordReader.java
Outdated
Show resolved
Hide resolved
ChrisSamo632
force-pushed
the
NIFI-12153
branch
from
9996740 to
0b60072
Compare
exceptionfactory
approved these changes
Oct 9, 2023
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for working through the feedback and making the adjustments @ChrisSamo632, the latest version looks good. +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12153 allow comments and confiugrable max string size in JSON Record Readers
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy[ ] New dependencies are documented in applicableLICENSEandNOTICEfilesDocumentation
[ ] Documentation formatting appears as expected in rendered files