NIFI-12157 Remove nifi-logging-utils and NiFiLog#7826
Closed
exceptionfactory wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-12157 Remove nifi-logging-utils and NiFiLog#7826exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory wants to merge 2 commits intoapache:mainfrom
Conversation
- Replaced NiFiLog references with direct references to SLF4J LoggerFactory
joewitt
reviewed
Oct 1, 2023
| IOUtils.copy(bis, new NullOutputStream()); | ||
| } catch (final IOException ioe) { | ||
| logger.info("Failed clearing out non-client response buffer due to: " + ioe, ioe); | ||
| logger.info("Failed clearing out non-client response buffer", ioe); |
Contributor
There was a problem hiding this comment.
We should avoid logging an exception at info level. In this case the output should be warn as it happening would be interesting to know why we weren't able to drain the response.
joewitt
reviewed
Oct 1, 2023
| @@ -56,7 +55,7 @@ public class FileBasedClusterNodeFirewall implements ClusterNodeFirewall { | |||
|
|
|||
Contributor
There was a problem hiding this comment.
On Line 105 for unknown host we should avoid including the exception. We know precisely why it was unknown and we're logging unknown host itself. In previous behavior the stack would not print without debug so this will preserve that plus intent anyway.
Contributor
Author
|
Thanks for the detailed notes on those methods @joewitt, I made the proposed adjustments and pushed the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12157 Removes the
nifi-logging-utilsmodule and replacesNiFiLogwrapper references with direct references to the standard SLF4JLoggerFactoryused throughout the repository.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation