NIFI-12163 Improve Syslog 5424 Line Handling#7835
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-12163 Improve Syslog 5424 Line Handling#7835exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Eliminated unused parseEvent method signatures from StrictSyslog5424Parser in favor of a single String line method - Eliminated intermediate conversion from String to byte array and back to String for Syslog Parser
asfgit
pushed a commit
that referenced
this pull request
Oct 4, 2023
- Eliminated unused parseEvent method signatures from StrictSyslog5424Parser in favor of a single String line method - Eliminated intermediate conversion from String to byte array and back to String for Syslog Parser Signed-off-by: Joseph Witt <joewitt@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12163 Improves Syslog handling in the
ParseSyslog5424andSyslog5424Readercomponents with the elimination of unnecessary String to byte conversion.Primary changes include streamlining the event parsing method to take a String instead of
ByteBuffercreated from a String. The supporting SyslogParser method accepts a String, so this approach avoids the intermediate conversion steps. Additional changes include providing the configured character set to the appropriateInputStreamReader, instead of having it default to platform encoding.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation