NIFI-12173 - Nifi Registry there's no documentation about OIDC connection#7842
NIFI-12173 - Nifi Registry there's no documentation about OIDC connection#7842marcelo225 wants to merge 10 commits intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this improvement @marcelo225, this is definitely an area where NiFi Registry is lacking documentation.
Unfortunately, the Registry implementation of OpenID Connect has some notable differences from NiFi itself, so the documentation section from the NiFi Admin Guide cannot be copied and pasted. In order to make some progress, however, removing the descriptive paragraphs and starting with just the table of properties would be helpful.
If you are interested in digging into the Registry OIDC implementation and updating the description to match, that's great. On the other hand, if you would like to move forward incrementally, focusing on the properties would be the best option.
exceptionfactory
left a comment
There was a problem hiding this comment.
@marcelo225 On further review, removing several paragraphs copied from the NiFi description should be sufficient for this documentation update to proceed. Please see the detailed comments, thanks!
nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
Outdated
Show resolved
Hide resolved
nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
Outdated
Show resolved
Hide resolved
nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
Outdated
Show resolved
Hide resolved
nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
Outdated
Show resolved
Hide resolved
nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
Outdated
Show resolved
Hide resolved
nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
Outdated
Show resolved
Hide resolved
nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
Outdated
Show resolved
Hide resolved
…sciidoc/administration-guide.adoc Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…sciidoc/administration-guide.adoc Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…sciidoc/administration-guide.adoc Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…sciidoc/administration-guide.adoc Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…sciidoc/administration-guide.adoc Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…sciidoc/administration-guide.adoc Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
…sciidoc/administration-guide.adoc Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
|
@exceptionfactory I'm done with it! |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @marcelo225, the latest version looks good! +1 merging
Summary
NIFI-12173
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-12173NIFI-12173Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation