NIFI-12233 - Parameter context provider for 1Password

[pvillard31]

Summary

NIFI-12233 - Parameter context provider for 1Password

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[pvillard31]

Some screenshots

[mattyb149]

I wonder if we should have something more specific in place than a RuntimeException, maybe a ParameterFetchException or something, perhaps as a follow on Jira?

[pvillard31]

Yeah that would probably make sense. I took a similar approach as in the other parameter providers we already have.

[exceptionfactory]

Thanks for implementing this new feature @pvillard31. The general approach looks good, and the 1Password Connect API seems straightforward. I noted a handful of minor wording and convention recommendations.

[pvillard31]

Thanks for the review @exceptionfactory. I believe I've addressed all of your comments.

[exceptionfactory]

Thanks for making the adjustments @pvillard31. This looks fairly close to completion, but I noted a few more adjustments related to URI construction. I also think it would be helpful to use the newer String text block language feature to define the expected JSON, which would make it much easier to read and maintain.

[pvillard31]

Additional commit to address your comments @exceptionfactory, thanks for the review!

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@013ca6d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7884   +/-   ##
=======================================
  Coverage        ?   50.61%           
  Complexity      ?    35115           
=======================================
  Files           ?     5255           
  Lines           ?   275729           
  Branches        ?    30441           
=======================================
  Hits            ?   139556           
  Misses          ?   126089           
  Partials        ?    10084           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[exceptionfactory]

Thanks for making the adjustments @pvillard31, the latest version looks good! +1 merging