NIFI-12219 Add Xodus Flow History Storage with Migration#7885
Merged
Conversation
- Added EntityStoreAuditService implementation using JetBrains Xodus libraries - Added FlowConfigurationHistoryMigrator for checking and migrating H2 databases containing Flow Configuration History to Xodus persistent store implementation
Contributor
|
Thanks for putting this together, @exceptionfactory! Code looks good. Did a quick test and everything appears to have been migrated properly. Able to see all of the events that I expected, including before/after values, timestamps, action taken, user... +1 will merge to support/nifi-1.x! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12219 Backports Flow Configuration History persistent storage using JetBrains Xodus as implemented for NIFI-12206 and adds migration capabilities to the support branch for subsequent NiFi version 1 releases.
The
EntityStoreAuditServiceclass contains the same implementation as merged for NIFI-12219, and the newFlowConfigurationHistoryMigratorsupports automated migration from H2 to Xodus on startup. The migrator checks for the presence of the H2 database file namednifi-flow-audit.mv.dband proceeds with migration when found. The migration process includes checking for older H2 binary formats, supporting all previous versions of H2 from 1.4 through 2.2. The migration process then uses available paging capabilities from the H2-basedAuditServiceto transfer records. Following successful migration, theFlowConfigurationHistoryMigratorrenamesnifi-flow-audit.mv.dbwith a backup timestamp extension.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation