Skip to content

NIFI-12294 Standardize NAR Entry Loading#7958

Merged
markap14 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-12294
Nov 1, 2023
Merged

NIFI-12294 Standardize NAR Entry Loading#7958
markap14 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-12294

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-12294 Updates the NarUnpacker to standardize loading of entries for NAR files, reducing duplicative naming normalization. Additional changes include updating the associated test class to reduce unnecessary parameter passing and method calls.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory marked this pull request as draft October 31, 2023 00:10
@exceptionfactory exceptionfactory force-pushed the NIFI-12294 branch 3 times, most recently from c6edf44 to f0cfdd4 Compare October 31, 2023 00:31
- Consolidated duplicative NAR file entry normalization
@exceptionfactory exceptionfactory marked this pull request as ready for review October 31, 2023 03:10
@markap14
Copy link
Contributor

markap14 commented Nov 1, 2023

Thanks for tackling that, @exceptionfactory. Looks like all tests (including system tests) are passing. Was able to startup with an existing work/ directory, and restart after deleting work/ directory and all appears to work as intended. Thanks for improving the code there! +1 will merge

@markap14 markap14 merged commit 945d8b5 into apache:main Nov 1, 2023
markap14 pushed a commit that referenced this pull request Nov 1, 2023
- Consolidated duplicative NAR file entry normalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants