NIFI-12294 Standardize NAR Entry Loading#7958
Merged
markap14 merged 1 commit intoapache:mainfrom Nov 1, 2023
Merged
Conversation
...work-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java
Fixed
Show fixed
Hide fixed
c6edf44 to
f0cfdd4
Compare
- Consolidated duplicative NAR file entry normalization
f0cfdd4 to
53f9d16
Compare
Contributor
|
Thanks for tackling that, @exceptionfactory. Looks like all tests (including system tests) are passing. Was able to startup with an existing work/ directory, and restart after deleting work/ directory and all appears to work as intended. Thanks for improving the code there! +1 will merge |
markap14
pushed a commit
that referenced
this pull request
Nov 1, 2023
- Consolidated duplicative NAR file entry normalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12294 Updates the
NarUnpackerto standardize loading of entries for NAR files, reducing duplicative naming normalization. Additional changes include updating the associated test class to reduce unnecessary parameter passing and method calls.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation