NIFI-12305 Optimize Regular Expressions in SampleRecord and EndpointMerger#7967
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-12305 Optimize Regular Expressions in SampleRecord and EndpointMerger#7967exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
...ain/java/org/apache/nifi/cluster/coordination/http/endpoints/AccessPolicyEndpointMerger.java
Fixed
Show fixed
Hide fixed
966b98a to
bedf17c
Compare
...ain/java/org/apache/nifi/cluster/coordination/http/endpoints/AccessPolicyEndpointMerger.java
Fixed
Show fixed
Hide fixed
- Updated SampleRecord range validation to split on comma and validate individual ranges - Updated AccessPolicyEndpointMerger to restrict the set of characters matched
bedf17c to
ed3b5be
Compare
Contributor
|
+1 LGTM, thanks for the improvement! Merging to main and support/nifi-1.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12305 Optimizes regular expression pattern definitions and usage in the
SampleRecordProcessor and theAccessPolicyEndpointMergerclass.Changes to
SampleRecordimprove range validation with an initial split on comma prior to validating individual ranges. This approach avoids potential issues with large numbers of ranges. Change toAccessPolicyEndpointMergerrestrict the set of characters to alphanumeric values and hyphen.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation