NIFI-12297 Standardize File Path resolution in Persistence Providers#7968
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-12297 Standardize File Path resolution in Persistence Providers#7968exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final String snapshotFilename = bucketId + "/" + flowId + "/" + version + "/" + version + SNAPSHOT_EXTENSION; | ||
| return new File(flowStorageDir, snapshotFilename); | ||
| final String versionExtension = version + SNAPSHOT_EXTENSION; | ||
| final Path snapshotLocation = Paths.get(getNormalizedId(bucketId), getNormalizedId(flowId), Integer.toString(version), versionExtension); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| } | ||
|
|
||
| static Path getArtifactPath(final String bucketId, final String groupId, final String artifactId) { | ||
| return Paths.get(sanitize(bucketId), sanitize(groupId), sanitize(artifactId)).normalize(); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
|
|
||
| private Path getNormalizedIdPath(final String id) { | ||
| final String normalizedId = getNormalizedId(id); | ||
| return Paths.get(normalizedId).normalize(); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
|
|
||
| private Path getNormalizedIdPath(final String id) { | ||
| final String normalizedId = id.replaceAll("\\.", "").replaceAll("/", "").trim(); | ||
| return Paths.get(normalizedId).normalize(); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12297 Standardizes file path resolution in the NiFi Registry File System Bundle and Flow Persistence Providers, as well as the file-backed client for system tests. These changes replace string concatenation and related strategies with a standard approach using Java NIO Paths. Using Paths ensures consistent directory separator handling and path normalization.
Additional changes include updating related unit tests to reuse shared identifier values.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation