Skip to content

NIFI-12297 Standardize File Path resolution in Persistence Providers#7975

Merged
markap14 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-12297
Nov 3, 2023
Merged

NIFI-12297 Standardize File Path resolution in Persistence Providers#7975
markap14 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-12297

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-12297 Standardizes file path resolution in the NiFi Registry File System Bundle and Flow Persistence Providers, as well as the file-backed Registry client for system tests.

These changes replace string concatenation and related strategies with a standard approach using Java NIO Paths. Using Paths ensures consistent directory separator handling and path normalization.

Additional changes include updating related unit tests to reuse shared identifier values.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@markap14
Copy link
Contributor

markap14 commented Nov 3, 2023

Thanks for the cleanup here @exceptionfactory all looks good to me. +1 will merge.

@markap14 markap14 merged commit c706877 into apache:main Nov 3, 2023
@markap14
Copy link
Contributor

markap14 commented Nov 3, 2023

Merged to main @exceptionfactory but it conflicts with the support/nifi-1.x branch. Jira targets that branch as well. If you'd like to have it merged to the support branch, do you mind pushing a new PR for that?

exceptionfactory added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants