NIFI-12297 Standardize File Path resolution in Persistence Providers#7975
Merged
markap14 merged 1 commit intoapache:mainfrom Nov 3, 2023
Merged
NIFI-12297 Standardize File Path resolution in Persistence Providers#7975markap14 merged 1 commit intoapache:mainfrom
markap14 merged 1 commit intoapache:mainfrom
Conversation
5cc0f62 to
ca15f88
Compare
.../src/main/java/org/apache/nifi/registry/provider/flow/FileSystemFlowPersistenceProvider.java
Fixed
Show fixed
Hide fixed
...in/java/org/apache/nifi/registry/provider/extension/FileSystemBundlePersistenceProvider.java
Fixed
Show fixed
Hide fixed
.../src/main/java/org/apache/nifi/registry/provider/flow/FileSystemFlowPersistenceProvider.java
Fixed
Show fixed
Hide fixed
ca15f88 to
a13a448
Compare
Contributor
|
Thanks for the cleanup here @exceptionfactory all looks good to me. +1 will merge. |
Contributor
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12297 Standardizes file path resolution in the NiFi Registry File System Bundle and Flow Persistence Providers, as well as the file-backed Registry client for system tests.
These changes replace string concatenation and related strategies with a standard approach using Java NIO Paths. Using Paths ensures consistent directory separator handling and path normalization.
Additional changes include updating related unit tests to reuse shared identifier values.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation