NIFI-12192 Add Codecov Reporting with JaCoCo#7995
NIFI-12192 Add Codecov Reporting with JaCoCo#7995exceptionfactory wants to merge 2 commits intoapache:mainfrom
Conversation
505396e to
6dc6450
Compare
- Added report-code-coverage profile to nifi-assembly for aggregation - Added Codecov reporting to Ubuntu Linux Job in ci-workflow - Added Codecov badge to README.md
6dc6450 to
bdf1278
Compare
|
@exceptionfactory thanks for the update, the code coverage will help improve confidence in the code base going forward. I've suggeted a couple of options to think about for improving the use of JaCoCo - more for consideration than blockers to merging this PR. As discussed elsewhere, would it be sensible to update the |
Thanks for the review and feedback @ChrisSamo632! I have also noticed that methods in that class have been unreliable in automated tests, so I changed the exclusion to apply to the entire |
ChrisSamo632
left a comment
There was a problem hiding this comment.
@exceptionfactory thanks for the updates and useful discussion RE options
LGTM 👍 will merge
Summary
NIFI-12192 Adds code coverage for unit tests using the JaCoCo Maven Plugin reporting to Codecov.
Codecov provides free reporting capabilities for open source projects and enables integration with GitHub workflows using the Codecov Action.
The implementation of code coverage reporting updates the GitHub
ci-workflowto run the Ubuntu Linux Java 21 job with JaCoCo coverage enabled. The JaCoCo plugin writes an aggregated report in XML, using thenifi-code-coveragemodule to aggregate coverage information based on an enumeration of dependencies. The Maven module is necessary for selecting and aggregating coverage reporting information. The Codecov Action reads the JaCoCo XML and sends it to Codecov for processing.The JaCoCo prepare-agent goal updates the
argLineproperty, which required removing custom locale information from the Ubuntu Linux job, instead relying on the default settings of the GitHub runner.Updates include adding a Codecov badge to the README for displaying coverage on the main branch.
Current code coverage information is available in Codecov for this feature branch.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation