Skip to content

NIFI-1874 Added Character Set Detection to IdentifyMimeType#8031

Closed
EndzeitBegins wants to merge 1 commit intoapache:support/nifi-1.xfrom
EndzeitBegins:NIFI-1874
Closed

NIFI-1874 Added Character Set Detection to IdentifyMimeType#8031
EndzeitBegins wants to merge 1 commit intoapache:support/nifi-1.xfrom
EndzeitBegins:NIFI-1874

Conversation

@EndzeitBegins
Copy link
Contributor

@EndzeitBegins EndzeitBegins commented Nov 15, 2023

  • Added mime.charset FlowFile attribute when not null for text MIME types

This is a backport of #8011 for NiFi v1.x.

Summary

NIFI-1874
NIFI-4550

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the mainsupport/nifi-1.x branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added mime.charset FlowFile attribute when not null for text MIME types
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting the changes @EndzeitBegins, looks good for the support branch! +1 merging

exceptionfactory pushed a commit that referenced this pull request Nov 15, 2023
- Added mime.charset FlowFile attribute when not null for text MIME types

This closes #8031

Signed-off-by: David Handermann <exceptionfactory@apache.org>
@exceptionfactory
Copy link
Contributor

Merged in f94e652

@EndzeitBegins
Copy link
Contributor Author

Perfect, thanks @exceptionfactory. 👍🏻

@EndzeitBegins EndzeitBegins deleted the NIFI-1874 branch November 15, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants