Skip to content

Nifi-12390 add more jvm metrics to 1.x line#8062

Closed
esecules wants to merge 1 commit intoapache:support/nifi-1.xfrom
esecules:NIFI-12390-1.x-more-jvm-metrics
Closed

Nifi-12390 add more jvm metrics to 1.x line#8062
esecules wants to merge 1 commit intoapache:support/nifi-1.xfrom
esecules:NIFI-12390-1.x-more-jvm-metrics

Conversation

@esecules
Copy link
Contributor

@esecules esecules commented Nov 24, 2023

  • Add init, committed, max, and used gauges for the non-heap
  • Add usage %, max, used, committed, init, and used-after-gc gauges for each GC-specific memory pool
  • Add count, memory used, and capacity for each buffer pool
  • retain the nifi_jvm_heap_non_usage metric that was renamed in the 2.x line
  • ❓ Would these additional metrics require a boolean property to enable them on back-port to 1.x?

Summary

NIFI-12390

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-12390
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-12390

Pull Request Formatting

  • Pull Request based on current revision of the mainsupport/nifi-1.x branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Add init, committed, max, and used gauges for the non-heap
- Add usage %, max, used, committed, init, and used-after-gc gauges for each GC-specific memory pool
- Add count, memory used, and capacity for each buffer pool
@esecules esecules marked this pull request as ready for review November 24, 2023 05:49
@esecules esecules marked this pull request as draft November 29, 2023 06:40
@esecules
Copy link
Contributor Author

esecules commented Nov 29, 2023

I found a way simpler way of doing this using prometheus DefaultExports. Putting back in draft.

@esecules esecules closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant