NIFI-12401: Allow combo editor to reference parameters#8068
Merged
rfellows merged 3 commits intoapache:mainfrom Nov 29, 2023
Merged
NIFI-12401: Allow combo editor to reference parameters#8068rfellows merged 3 commits intoapache:mainfrom
rfellows merged 3 commits intoapache:mainfrom
Conversation
- Allow combo editor to reference parameters.
Contributor
|
reviewing... |
rfellows
requested changes
Nov 28, 2023
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
Looks good as long as there is an active parameter context. If not there are issues.
...rc/main/nifi/src/app/ui/common/property-table/editors/combo-editor/combo-editor.component.ts
Show resolved
Hide resolved
- Addressing review feedback. - Handling corner cases where there is no parameter context and where there are no parameters in a bound parameter context.
rfellows
reviewed
Nov 29, 2023
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
The changes look good...
Just need a couple of stylistic fixes (prettier pointed them out).
Two I commented on to change to use arrow function rather than fixing the spacing for an inline function definition.
The others you can just run prettier for.
...in/nifi/src/app/ui/common/property-table/editors/combo-editor/combo-editor.component.spec.ts
Outdated
Show resolved
Hide resolved
...in/nifi/src/app/ui/common/property-table/editors/combo-editor/combo-editor.component.spec.ts
Outdated
Show resolved
Hide resolved
- Fixing formatting issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-12401: