Skip to content

NIFI-12410 Refactored to allow for 'Starting Row' to have flowfile attributes scope.#8119

Closed
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-12410
Closed

NIFI-12410 Refactored to allow for 'Starting Row' to have flowfile attributes scope.#8119
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-12410

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Dec 4, 2023

Summary

NIFI-12410
Refactored the 'Starting Row' to have flowfile attributes scope and changed the validator on this property from NON_NEGATIVE_INTEGER_VALIDATOR to POSITIVE_INTEGER_VALIDATOR to prevent users from entering 0.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @dan-s1, the changes look good! +1 merging

exceptionfactory pushed a commit that referenced this pull request Dec 5, 2023
This closes #8119

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit ab8a82b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants