Skip to content

NIFI-12408 Added pretty print option when destination is content.#8156

Closed
dan-s1 wants to merge 2 commits intoapache:mainfrom
dan-s1:NIFI-12408
Closed

NIFI-12408 Added pretty print option when destination is content.#8156
dan-s1 wants to merge 2 commits intoapache:mainfrom
dan-s1:NIFI-12408

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Dec 13, 2023 •
edited
Loading

Summary

NIFI-12408

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

exceptionfactory
exceptionfactory requested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @dan-s1, I noted a few small recommendations.

exceptionfactory
exceptionfactory approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @dan-s1, the latest version looks good! +1 merging

exceptionfactory pushed a commit that referenced this pull request Dec 16, 2023
@dan-s1 @exceptionfactory
NIFI-12408 Added Pretty Print Property to AttributesToJSON
96b0b12 
This closes #8156

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 1ddb5c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dan-s1 @exceptionfactory