Skip to content

Nifi 12505 system diagnostics#8190

Merged
mcgilman merged 3 commits intoapache:mainfrom
rfellows:NIFI-12505-systemDiagnostics
Dec 28, 2023
Merged

Nifi 12505 system diagnostics#8190
mcgilman merged 3 commits intoapache:mainfrom
rfellows:NIFI-12505-systemDiagnostics

Conversation

@rfellows
Copy link
Contributor

Summary

NIFI-12505

  • Added System Diagnostics dialog
  • Refactored Status History to follow the same pattern where we use one action to initiate the load and open of the dialog rather than letting the dialog initiate the load after it is opened.

@rfellows rfellows added the ui Pull requests for work relating to the user interface label Dec 27, 2023
@mcgilman mcgilman self-requested a review December 27, 2023 16:09
@mcgilman
Copy link
Contributor

Will review...

@rfellows rfellows force-pushed the NIFI-12505-systemDiagnostics branch from 0d1d855 to bb85976 Compare December 28, 2023 13:41
Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rfellows! Looks great, just a few small things I noticed below.

@mcgilman mcgilman self-requested a review December 28, 2023 20:20
Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @rfellows! Looks great. +1

@mcgilman mcgilman merged commit e15aecc into apache:main Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Pull requests for work relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants