Skip to content

NIFI-12572 Refactor components in azure bundle using current API methods#8210

Closed
EndzeitBegins wants to merge 2 commits intoapache:mainfrom
EndzeitBegins:NIFI-12572
Closed

NIFI-12572 Refactor components in azure bundle using current API methods#8210
EndzeitBegins wants to merge 2 commits intoapache:mainfrom
EndzeitBegins:NIFI-12572

Conversation

@EndzeitBegins
Copy link
Contributor

@EndzeitBegins EndzeitBegins commented Jan 6, 2024

Summary

Refactor tests and components in azure bundle to use updated APIs from NIFI-12452.

Additionally, makes use of newer Java APIs, e.g. List.of and Set.of for declaration of relationships and properties.

NIFI-12572

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup and improvements @EndzeitBegins. The majority of these changes look good, I just noted a couple very minor adjustment recommendations.

@EndzeitBegins
Copy link
Contributor Author

Thank you for your reviews of this and the other PRs @exceptionfactory. Also for taking on the merge process.

I've supplied a commit that applies your suggestions.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @EndzeitBegins, the latest version looks good! +1 merging

@EndzeitBegins EndzeitBegins deleted the NIFI-12572 branch January 18, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants