Skip to content

NIFI-12613 Align type-safe access to allowableValue with its declaration#8260

Closed
EndzeitBegins wants to merge 1 commit intoapache:mainfrom
EndzeitBegins:NIFI-12613
Closed

NIFI-12613 Align type-safe access to allowableValue with its declaration#8260
EndzeitBegins wants to merge 1 commit intoapache:mainfrom
EndzeitBegins:NIFI-12613

Conversation

@EndzeitBegins
Copy link
Copy Markdown
Contributor

Summary

NIFI-12613

Aligns the access site of "allowableValues" in PropertyValue with the declaration site in PropertyDescriptor.Builder. The method asDescribedValue was introduced recently and hasn't been part of a proper release yet. I think its a good time to align the type and naming scheme with the configuration site before the inclusion in a first release, as it would be a breaking change then.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@EndzeitBegins EndzeitBegins changed the title NIFI-12613 Align type-safe access to allowableValue with it's declaration NIFI-12613 Align type-safe access to allowableValue with its declaration Jan 17, 2024
Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for introducing this change @EndzeitBegins, the approach looks good, and as you noted, this is a good time to make the change prior to the next milestone release. +1 merging

@EndzeitBegins EndzeitBegins deleted the NIFI-12613 branch January 18, 2024 05:54
@EndzeitBegins
Copy link
Copy Markdown
Contributor Author

Thank you for the quick review & merge @exceptionfactory. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants