NIFI-12613 Align type-safe access to allowableValue with its declaration#8260
Closed
EndzeitBegins wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-12613 Align type-safe access to allowableValue with its declaration#8260EndzeitBegins wants to merge 1 commit intoapache:mainfrom
EndzeitBegins wants to merge 1 commit intoapache:mainfrom
Conversation
exceptionfactory
approved these changes
Jan 18, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for introducing this change @EndzeitBegins, the approach looks good, and as you noted, this is a good time to make the change prior to the next milestone release. +1 merging
Contributor
Author
|
Thank you for the quick review & merge @exceptionfactory. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12613
Aligns the access site of "allowableValues" in
PropertyValuewith the declaration site inPropertyDescriptor.Builder. The methodasDescribedValuewas introduced recently and hasn't been part of a proper release yet. I think its a good time to align the type and naming scheme with the configuration site before the inclusion in a first release, as it would be a breaking change then.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation