Skip to content

NIFI-12725 Update json-schema-validator to 1.3.0#8341

Closed
mr1716 wants to merge 4 commits intoapache:mainfrom
mr1716:NIFI-12725
Closed

NIFI-12725 Update json-schema-validator to 1.3.0#8341
mr1716 wants to merge 4 commits intoapache:mainfrom
mr1716:NIFI-12725

Conversation

@mr1716
Copy link
Copy Markdown
Contributor

@mr1716 mr1716 commented Feb 1, 2024

Summary

NIFI-12725

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mr1716, the changeset includes socketbroker, which needs to be reverted.

<groupId>com.exceptionfactory.socketbroker</groupId>
<artifactId>socketbroker</artifactId>
<version>1.1.0</version>
<version>1.3.0</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is for a different library and should be reverted.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exceptionfactory thanks. Change reverted.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial build results show test failures for JSON Schema components, so it appears that version 1.3.0 changed something substantively. This will require closer evaluation.

@exceptionfactory
Copy link
Copy Markdown
Contributor

The changelog for version 1.2.0 indicates breaking changes, same for 1.3.0. The json-schema-validator does not follow semantic versioning, so this upgrade will require code changes. I am closing this pull request for now, pending further changes necessary to adapt to API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants