NIFI-12708 UnpackContent should allow the user to specify a character set to apply in reading paths and filenames#8350
Closed
umarhussain15 wants to merge 5 commits intoapache:mainfrom
Conversation
…or filenames in zip unpacking The processor can now take a filename encoding parameter and pass it to zip unpacking. This will allow user to unzip files with specific encoding to get correct filenames in output. This for example help with zip files created on Windows which by default uses Cp437 for filename encoding. If the filename contains special character like German alphabet ä, ü etc., decoding this with Linux's default encoding usually UTF8 output will contain `?` in it. When the same file is processed with property set with `Cp437`, the processor outputs correct filenames with special characters preserved. Signed-off-by: Umar Hussain <umarhussain.work@gmail.com>
Signed-off-by: Umar Hussain <umarhussain.work@gmail.com>
joewitt
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Outdated
Show resolved
Hide resolved
joewitt
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Outdated
Show resolved
Hide resolved
joewitt
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Outdated
Show resolved
Hide resolved
joewitt
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Outdated
Show resolved
Hide resolved
joewitt
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Outdated
Show resolved
Hide resolved
joewitt
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Outdated
Show resolved
Hide resolved
dan-s1
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Show resolved
Hide resolved
joewitt
reviewed
Feb 2, 2024
...standard-processors/src/test/java/org/apache/nifi/processors/standard/TestUnpackContent.java
Show resolved
Hide resolved
dan-s1
reviewed
Feb 2, 2024
...ifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
Outdated
Show resolved
Hide resolved
Contributor
|
@umarhussain15 Great start here. Left you a series of comments plus Dan just left one to consider as well. Thanks! |
Signed-off-by: Umar Hussain <umarhussain.work@gmail.com>
...standard-processors/src/test/java/org/apache/nifi/processors/standard/TestUnpackContent.java
Outdated
Show resolved
Hide resolved
The unknown special character check is switched now to input unicode special character in zip creation and then check for it in output of processor. Signed-off-by: Umar Hussain <umarhussain.work@gmail.com>
Signed-off-by: Umar Hussain <umarhussain.work@gmail.com>
exceptionfactory
approved these changes
Feb 7, 2024
Contributor
|
Thanks @umarhussain15 - good work and good discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12708: add option in UnpackContent to specify encoding charset for filenames in zip unpacking
The processor can now take a filename encoding parameter and pass it to zip unpacking. This will allow
user to unzip files with specific encoding to get correct filenames in output.
This for example help with zip files created on Windows which by default uses Cp437 for filename encoding.
If the filename contains special character like German alphabet ä, ü etc., decoding this with Linux's
default encoding (usually UTF8) will contain
?in output. When the same file is processed with propertyset with
Cp437, the processor outputs correct filenames with special characters preserved.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation