Controller Services - Addressing issues with transitive referencing components#837
Closed
mcgilman wants to merge 2 commits intoapache:masterfrom
Closed
Controller Services - Addressing issues with transitive referencing components#837mcgilman wants to merge 2 commits intoapache:masterfrom
mcgilman wants to merge 2 commits intoapache:masterfrom
Conversation
…e returned. NIFI-2543: - Ensuring we have permissions before attempting to reload a controller service.
Contributor
|
Reviewing |
- Ensuring we can enable/disable services with transitive referencing components. - Ensuring we cannot enable/disable services with unauthorized referencing components.
Contributor
|
+1 Visually verified code and did a contrib check build. In a standalone cluster tested many different levels of transitive dependencies using DetectDuplicate -> DistributeMapCacheClientService -> SSLContextService and enabling and disabling referenced components, and all behaved as expected. Looks good @mcgilman, I will merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-2542: - Ensuring transitive referencing components are able to be returned.
NIFI-2543: - Ensuring we have permissions before attempting to reload a controller service.