Skip to content

NIFI-12781: Remove file location from provenance UPLOAD event#8397

Closed
Lehel44 wants to merge 1 commit intoapache:mainfrom
Lehel44:NIFI-12781
Closed

NIFI-12781: Remove file location from provenance UPLOAD event#8397
Lehel44 wants to merge 1 commit intoapache:mainfrom
Lehel44:NIFI-12781

Conversation

@Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented Feb 12, 2024

Summary

NIFI-12781

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @Lehel44. Removing the location field makes sense here, as the destination location is already captured in the Transit URI. As the primary goal of adding the UPLOAD event was to track the size transmitted, without creating a temporary FlowFile for the SEND event, this approach looks good, and makes sense given that the API changes are not yet released. +1 merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants