Merged
Conversation
scottyaslan
force-pushed
the
NIFI-12774
branch
3 times, most recently
from
b6cd3a7 to
dce5508
Compare
Contributor
|
Will review... |
mcgilman
reviewed
Feb 13, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Nice work @scottyaslan! I've left a few comments below.
...i-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts
Outdated
Show resolved
Hide resolved
...tems/remote-process-group/edit-remote-process-group/edit-remote-process-group.component.html
Outdated
Show resolved
Hide resolved
scottyaslan
force-pushed
the
NIFI-12774
branch
from
69a056f to
b2d3333
Compare
mcgilman
approved these changes
Feb 14, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the updates @scottyaslan! +1 will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-12774